ettins cast haste on player instead of themselves

[GoogleCodeExporter]

lol I'm sorry but thats just the greatest bug ever

ettins in dragon valley 4f.  confirmed bug.

Original issue reported on code.google.com by tric...@gmail.com on 19 Jun 2011 at 12:10

[GoogleCodeExporter]

confirmed that mob id 45373 does this (ettin)

mainly a note to self for when I go digging through the code

Original comment by tric...@gmail.com on 19 Jun 2011 at 12:40

[GoogleCodeExporter]

this should fix it but I cant test it right now

UPDATE mobskill SET changetarget=0 where mobid = 45373 && actno = 0;
UPDATE mobskill SET changetarget=0 where mobid = 45505 && actno = 0;

you have to let them beat on you for a while before they'll haste you, but if 
you run that and let them beat on you until they cast, you'll know right away.  
They'll either cast it on themselves or you, themselves if this works

Original comment by tric...@gmail.com on 19 Jun 2011 at 12:53

[GoogleCodeExporter]

hm nope, that wasn't the problem, sry I must have read the code wrong

Original comment by tric...@gmail.com on 19 Jun 2011 at 1:10

[GoogleCodeExporter]

I dont see anything in the code specific to this mob, and that might mean that 
many more mobskills are broken and this is just one obvious symptom.  we should 
probably find the cause of this asap

Original comment by tric...@gmail.com on 19 Jun 2011 at 1:14

[GoogleCodeExporter]

i made it hardcoded only need to fix the haste effect the move speed works fine 
for ettin now. and maybe i need to add a timer.

Original comment by Nuijen...@gmail.com on 19 Jun 2011 at 9:27

[GoogleCodeExporter]

fixed in r488. 

Original comment by Nuijen...@gmail.com on 19 Jun 2011 at 11:11

• Changed state: Fixed

[GoogleCodeExporter]

reopened since my fix breaks the npctalk :-(

Original comment by Nuijen...@gmail.com on 19 Jun 2011 at 12:39

[GoogleCodeExporter]

Original comment by Nuijen...@gmail.com on 19 Jun 2011 at 12:40

• Changed state: Accepted

[GoogleCodeExporter]

its also Ettins in Forgotten Island, I checked the high lizardmans heals and 
guess what, he heals you when he or a lizardman friend is low on hp lol

Original comment by L1Vala...@gmail.com on 19 Jun 2011 at 4:45

[GoogleCodeExporter]

awesome, thank you I've been meaning to test that too.  So it seems any mob
spell they're supposed to cast on themselves they cast on their target
instead.  That may make it easier to spot the code change that caused this.
I've glanced in l1monster, l1npcinstance and nothing jumped out at me yet,
so it may be in another class I haven't thought of or I overlooked it

Original comment by tric...@gmail.com on 19 Jun 2011 at 4:49

[GoogleCodeExporter]

It could be a simple db fix but I cant remember, If I had 1 of my old event 
data I could of probably told you what the problem was because in the event I 
had a mob that healed its group and not you. but ive lost the data :(

Original comment by L1Vala...@gmail.com on 19 Jun 2011 at 4:55

[GoogleCodeExporter]

I'm 99% sure this is a code problem.  I remember a merge caused this once
before, but when I marked it fix I didn't specifiy what revision or what
change specifically fixed it.

Original comment by tric...@gmail.com on 19 Jun 2011 at 4:59

[GoogleCodeExporter]

Zylia thankfully had a copy of the old linret events, I checked and I think 
your right it must be in the code. the database entries are the same for my 
event mobs. a few more mobs that are probably affected but not tested are 
Cerenis and Dread Queen Laia.

Original comment by L1Vala...@gmail.com on 19 Jun 2011 at 5:17

[GoogleCodeExporter]

its a code problem. the l1skilluse is broken thats why it gives the error 8 
problem

Original comment by Nuijen...@gmail.com on 19 Jun 2011 at 5:19

[GoogleCodeExporter]

in case its useful to anyone and you don't know, you can check out earlier
versions of the code with the --revision argument

example:

svn checkout *http*://l1j-en.googlecode.com/svn/trunk/ l1j-en-370 --revision
370

will do a full checkout of the code base as of revision 370 (where we
started updating, so its the last epU version of the code base), and put it
in the directory l1j-en-370.

not sure how to do that on windows with the gui tools, but it should be an
option someplace

Original comment by tric...@gmail.com on 19 Jun 2011 at 5:34

[GoogleCodeExporter]

Fixed in r520.

Original comment by bm3...@gmail.com on 22 Jun 2011 at 5:49

• Changed state: Fixed

[GoogleCodeExporter]

Reopened, since I had to roll back my previous fix.  jp2 has a completely 
rewritten mobskilluse class, so maybe we should use some version of that 
instead of trying to fix the mess that's currently there.

Original comment by bm3...@gmail.com on 25 Jun 2011 at 9:42

• Changed state: Accepted

[GoogleCodeExporter]

Original comment by tric...@gmail.com on 27 Jun 2011 at 3:57

• Changed state: Fixed