random disconnects

[GoogleCodeExporter]

players are randomly getting dc'd far more than normal.

We moved the server thinking it was an ISP problem, but its still happening.  
Thats making the odds lean towards this being a code problem.

Only things coming to mind are clientthread and various packet handlers.  
They've all been changed in the merge, and then changed many times since.

Would like it if someone could confirm this on another server as well.  It's 
random so it may be hard to confirm without another live server or test server 
with decent population.

Me and my gf, sitting in the same house, same router, same o/s, same client 
version, I can go all day without a single dc just sitting idle while she gets 
dc'd reliably every 10-20 minutes or so.

some players report updating against live helps, but I find this hard to 
believe (and I tested it on my gf's, didn't help).  Since we're using a 
connector the only updates we'll get from live are gfx/snds if I understand 
correctly.

Original issue reported on code.google.com by tric...@gmail.com on 21 Jun 2011 at 4:49

[GoogleCodeExporter]

as a bandaid I'm going to start merging my old "mp bug" fix to our current 
code, and see if it helps.  As a side affect of how it works, it forces keep 
alive packets to be sent out more often, so maybe it'll help.  If it does at 
least that'd be a hint about why, and proof its a code problem

Original comment by tric...@gmail.com on 21 Jun 2011 at 4:50

[GoogleCodeExporter]

first of all the keepalive packets are broken and second off all the server 
pingpacket is missing i added it sveral times long time ago everytime you guys 
remove it. and keepalive C is disabled. it should send everytime a ping too the 
player and the server should ping the player and the client. this future is 
broken and missing

Original comment by Nuijen...@gmail.com on 21 Jun 2011 at 7:25

[GoogleCodeExporter]

i made a new ping packet thing i go test it now if i dont find any problem then 
i send it to you tricid.

Original comment by Nuijen...@gmail.com on 21 Jun 2011 at 1:03

[GoogleCodeExporter]

got it done seems to work well. need someone that can test it with players 
online

Original comment by Nuijen...@gmail.com on 21 Jun 2011 at 1:28

[GoogleCodeExporter]

this is a change I'll test on our live server, extra keep alive packets
shouldn't hurt anything

let me get us moved over to git first though please

Original comment by tric...@gmail.com on 21 Jun 2011 at 1:30

[GoogleCodeExporter]

sure ill wait.

Original comment by Nuijen...@gmail.com on 21 Jun 2011 at 2:09

[GoogleCodeExporter]

as a side effect of r507, this is now fixed.  It force sends keep alive 
packets.  It's not a "proper" fix for this specific issue, but it does fix 
another major bug, so it's basically required, and fixes this, so I'm making 
this one fixed as well lol

hope all that makes sense

Original comment by tric...@gmail.com on 22 Jun 2011 at 1:15

• Changed state: Fixed