Open sitiom opened 2 years ago
It is an issue.
have no idea how to fix - looks like Console.ReadKey
doesn't get Modifier while ctrl-BS is pressed:
@sitiom this should be fixed in the latest Rust version, please feel free checkout the main
branch
Thanks. This is fixed now. However, when trying to edit around Neovim for some time, I get this error:
This command doesn't work too:
So far the Rust version is not on par with the C# version. It doesn't have the features incorporated in #29. Hopefully, you can add them too.
thanks for reporting!
I just updated 0.1.3 at: https://github.com/Watfaq/PowerSession/pull/38
and nvim seems working fine: https://asciinema.org/a/499016
please feel free to try it out
Everything seems to be good, and Neovim is somehow working fine now. But the terminfo for Windows terminal should be ms-terminal
as fixed in #32.
powersession upload
without any arguments errors out:
Also, The OS
info is not showing up on the recording. I guess the user agent doesn't match the format like in the C# version:
right, looks like it has a requirement different from the sample here: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/User-Agent#microsoft_edge_ua_string
i'll fix
The last thing would be to add the --version
flag, which is missing currently.
0.1.4 should have all of this. one thing I don't understand is the OS is only showing Windows
for me, not Windows 10
though the UA looks like this: [TRACE] ua: asciinema/2.0.0 rust/1.55.0 Windows/10-10.0.22000-SP0
you see anything?
It looks like it has been like that recently; even in the C# version, new uploads show up as Windows
. Other than that, everything seems to have been resolved now, thanks!
@ibigbug Just a question, is the C# version still maintained? I see you released both versions of them recently. I would like to update the scoop manifest accordingly. If you plan to deprecate the C# version, I suggest bumping the tag to v2.0.0 for the rust version instead of prefixing it with cs-
or rs-
for consistency.
Great to know, thanks!
The C# version won't be much updated. The latest release was a fix for the breaking API change from System.CommandLine nuget. However PRs are still well come if people are interested ;)
On latest commit (https://github.com/Watfaq/PowerSession/commit/37da8b5d8b3f6b60469430f781d7eeb7d4e7e824). It actually also happens on the latest release by doing
powersession rec test.cast -c pwsh
.