Recorder should not capture all environment vars

Watfaq / PowerSession

Record a Session in PowerShell

MIT License

152 stars 9 forks source link

Recorder should not capture all environment vars #9

Closed ariasemis closed 3 years ago

ariasemis commented 4 years ago

Thank you for making this, it's really awesome!

I noticed that the output file lists all my env variables, which is not ideal when sharing it.

According to the spec from asciicinema:

Official asciinema recorder captures only SHELL and TERM by default. All implementations of asciicast-compatible terminal recorder should not capture any additional environment variables unless explicitly permitted by the user.

Do you think this could be fixed?

Thank you again!!

comnam90 commented 3 years ago

It would be good to get this issue addressed

ibigbug commented 3 years ago

thanks for the contribution!

release created: https://github.com/ibigbug/PowerSession/releases/tag/release-1.3.0