search

Watson-Personal-Assistant / skill-sdk-nodejs

Other
2 stars 6 forks source link

add condition to only use env creds for wcs nlu #52

Closed neilsbhargava closed 6 years ago

neilsbhargava commented 6 years ago

A PR for a bug discovered by investigating this issue regarding regex NLU engine failing to initiate when the skill is started in "wcs" and "regexp" mode with a corresponding .env file containing the wcs credentials.

erezbi commented 6 years ago

We have to get this tested before merging it. Also, changed the PR to merge into 'pre-release' instead of 'master'.

neilsbhargava commented 6 years ago

Anything else required from my side?

erezbi commented 6 years ago

@offerakrabi - I guess we're missing a test for this. How should we test this?

troyibm commented 6 years ago

@erezbi is this going to get into the 11-01 release??

offerakrabi commented 6 years ago

@erezbi we can close this, added this fix to the wa api key PR