search

WatsonGroupTCD / J2suscep

See https://github.com/WatsonGroupTCD/J2suscep/wiki
MIT License
3 stars 3 forks source link

Example #5

Closed mturiansky closed 3 years ago

mturiansky commented 3 years ago

review for JOSS

The example Mn complex is quite complex and has many degrees of freedom. It seems like a simpler system could be devised that would better illustrate how to use the code. I would imagine a two spin system with only one coupling constant should be feasible. (I understand that this doesn't show the major capability of the code of being able to sort out singular solutions and achieving some self-consistency, but I think it would be very useful for new users to see such an example.)

mfherbst commented 3 years ago

I agree and suggest that a simpler example or a few simpler examples, which could also serve very well as unit test cases.

Swetanshu commented 3 years ago

Simpler examples have been provided as part of the package. These examples have also been discussed in the wiki and are being used as test cases.