search

WatsonLab / MAGpy

Snakemake pipeline for downstream analysis of metagenome-assembled genomes (MAGs) (pronounced mag-pie)
62 stars 23 forks source link

Tests are written for Python 2.7 #9

Closed halexand closed 5 years ago

halexand commented 5 years ago

Hello!

I installed MAGpy and am excited to try it out! I am trying to run it with MAGpy-3.5 env that was defined in the envs. If I do this I noticed that snakemake -s MAGpy test doesn't work and throws errors e.g.: 

  File "test/scripts/test_phylophlan.py", line 17
    print phydir + " does not exist or isn't a directory"
               ^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print(phydir + " does not exist or isn't a directory")?

Generally speaking, is MAGpy better run with 2.7 than 3.5? If not, I have made a PR (#8) with a fix to the tests.

Thanks again for the great platform-- I am excited to work with it.

halexand commented 5 years ago

I think I figured it out for myself-- Checkm is still limited to 2.7. Makes sense now.