Closed r24mille closed 6 years ago
Hmm... it seems #131 auto-closed this issue when it got merged in (?) Anyway, it may be useful to split the work up into multiple issues or re-open this issue. I don't have permissions, since I'm not a collaborator.
Reopening as it needs more work.
Currently, there are many tests in the
test
directory that call external resources, rather than mocking requests/responses. Some also require environment variables (e.g. settingEIA_KEY
intest_eia.py
). This is causing issues in Travis and we're losing the value from existing continuous integration work that has been done.I propose the following changes:
travis.yml
so that the build server only runs unit tests when pull requests are opened. I believe this is just changing the[nosetests](https://nose.readthedocs.io/en/latest/usage.html)
script on line 26 to something like:This only leaves one question: What automated process should run the integration tests? Should the maintainers just be responsible for running integration tests before formalizing a release? Should the integration tests just be there for developers to run out-of-band so they can be confident in their code before opening pull requests?