search

WattTime / pyiso

Python client libraries for ISO and other power grid data sources.
http://pyiso.readthedocs.org/
Other
239 stars 112 forks source link

Fixes NBPowerClient load forecast daylight saving / standard time parsing #191

Closed r24mille closed 6 years ago

r24mille commented 6 years ago

This commit makes three key changes to load forecasts:

  1. NBPower's timestamp format for standard time is handled (e.g. in 20171106000000AS the "AS" indicates Atlantic Standard time).
  2. When transitioning from standard time to daylight saving time, the "3:00am" timestamp (e.g. 20170312030000AD) is repeated. When duplicate timestamps exist, the latest value is used.
  3. The load date range now only stitches "latest" together with the load forecast if start_at is before "now". Otherwise making that (useless) request is now conditionally skipped.

Unit tests have been added for all these scenarios. Fixes #186.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.1%) to 62.754% when pulling 7eabfbd58305ce02bd6043e866b797d10bc6a77e on r24mille:186_fix_nbpower_forecast_dst_handling into 96d1d9b744025a8f394360be944e1575c11a453d on WattTime:master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.1%) to 62.754% when pulling 7eabfbd58305ce02bd6043e866b797d10bc6a77e on r24mille:186_fix_nbpower_forecast_dst_handling into 96d1d9b744025a8f394360be944e1575c11a453d on WattTime:master.