search

WattTime / watttime-python-client

A software development kit for the WattTime API, showing basic examples of usage.
7 stars 6 forks source link

Request to add custom SSL certificate verification #23

Open malakhalifa0 opened 2 months ago

malakhalifa0 commented 2 months ago

Issue #24

Currently, watttime/api.py does not specify custom SSL certificate verification when making requests to the WattTime API, instead, it uses the system defaults. For enhanced security and compatibility with specific certificate requirements, we need to update the function to use a custom certificate location for SSL verification.

This would be really useful in the cases where we would need to trust a specific certificate and would improve the security and compatibility of the API login process.

sam-watttime commented 2 months ago

Hi @malakhalifa0, thanks for the PR! It looks like tests are failing because self.certificate_location is never set. Could you add an optional argument to the init of WattTimeBase for this?

@xginn8 any thoughts on what the default value for that argument should be?

malakhalifa0 commented 1 month ago

Hi @malakhalifa0, thanks for the PR! It looks like tests are failing because self.certificate_location is never set. Could you add an optional argument to the init of WattTimeBase for this?

@xginn8 any thoughts on what the default value for that argument should be?

Thanks for your feedback! For some reason self.certificate_location wasn't initialised in this branch, merging it with main updated the code properly. Let me know if the tests pass now. Thanks!