search

Watts-Lab / commonsense-platform

Commonsense platform
https://commonsense.seas.upenn.edu
1 stars 0 forks source link

Convert backend to typescript #115

Open amirrr opened 5 months ago

amirrr commented 5 months ago

There needs to be multiple steps:

Migrate to the newer sequelize-typescript for typescript database models. Convert every file to typescript and continue in typescript (checkJs: false) Go through every file and fix typing issues (checkJs: true)

markwhiting commented 3 hours ago

What's the status on this effort? I think we perhaps decided we couldn't do some things because of some fundamental problems, but I forget how we finalized that discussion. Any updates @amirrr

amirrr commented 3 hours ago

sequilize typescript is still work in progress https://sequelize.org/docs/v6/other-topics/typescript/ and there are some small configurations needed to move to typescript. But there are ways around that and we can do that. I am working on the typescript branch on figuring out the sequilize part but once that's done, we can slowly convert to typescript. I say let's keep this open but mostly focus on getting it to run with typescript complier and then make the change once stable.