Watts-Lab / commonsense-platform

Commonsense platform
https://commonsense.seas.upenn.edu
1 stars 0 forks source link

Treatment of statements is inconsistent #150

Open markwhiting opened 3 months ago

markwhiting commented 3 months ago

This likely has 2 layers:

  1. some statements have trailing punctuation and capitalization (so we aren't cleaning them correctly somewhere in the pipeline)
  2. when statements do not have those things, they are displayed without them on the platform.

I think the behavior we would like is that statements should be stored in a consistent state (i.e., all have trailing punctuation and capitalization or all not have those things) and displayed in a consistent way (i.e., always shown with the first letter capitalized and a period at the end).

Additionally, I think we want to clean up any existing statements that have these issues without breaking IDs.

To be finished, we should have a test in place that checks that statements are correctly formatted after ingestion and are correctly formatted at render time.

JamesPHoughton commented 2 months ago

Steps:

blockers:

JamesPHoughton commented 1 month ago

Goals is to make the presentation consistent, more than to make it any one specific format.