Closed acao22 closed 2 months ago
0 | 11 | 0 | 0 | 0 |
Details:
Merge pull request #152 from Watts-Lab/111-removing-hardcoded-variable-names | |||
Project: Commonsense | Commit: 7e81805cb8 |
||
Status: Passed | Duration: 00:44 💡 | ||
Started: Jul 9, 2024 5:30 PM | Ended: Jul 9, 2024 5:31 PM |
I just resolved the merge conflict, should be good to go now. There is one review about connecting surveyData.json and answers.js together; I've fixed that but for some reason I can't resolve the comment. Thanks!
I just resolved the merge conflict, should be good to go now. There is one review about connecting surveyData.json and answers.js together; I've fixed that but for some reason I can't resolve the comment. Thanks!
No problem this is good enough. just check to make sure this works on your local system and then merge
You can fix the package-lock.json by running npm i --package-lock-only
@amirrr , is it possible for you to help me close the requested change? I don't see where I can indicate it is resolved but I combined surveyData.json and answers.js so it should be fixed, I can't merge without resolving that change. Thanks!
Description: This pull request refactors MultiStepForm.tsx to eliminate hard-coded variables and use dynamic survey data from questions.ts, so that all the question and answer data is dynamically loaded & handled
Changes:
Thanks and let me know if there's anything I need to fix!