Watts-Lab / deliberation-empirica

Empirica V2 framework
MIT License
5 stars 0 forks source link

Pull score function from surveys repo for team viability survey #228

Closed kepstein23 closed 1 year ago

kepstein23 commented 1 year ago

closes #215

I'm pretty sure this is working - no errors are thrown, but am not sure how to test that this is the function that's actually being used.

cypress[bot] commented 1 year ago



Test summary

7 3 0 0


Run details

Project Deliberation
Status Failed
Commit 4611d158f4
Started Aug 5, 2022 7:23 PM
Ended Aug 5, 2022 7:29 PM
Duration 05:51 💡
OS Linux Ubuntu - 20.04
Browser Chrome 103

View run in Cypress Dashboard ➡️


Failures

02_Batch_Canceled.js Failed
1 Batch canceled > from intro steps
2 Batch canceled > from game
04_No_Experiments_Available.js Failed
1 No experiments available > has no games available

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

github-actions[bot] commented 1 year ago
/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/Surveys/team_viability.jsx
  12:1   error  Expected indentation of 2 spaces but found 4            indent
  12:5   error  Expected space(s) after "return"                        keyword-spacing
  13:9   error  Expected indentation of 6 space characters but found 8  react/jsx-indent
  13:45  error  Strings must use singlequote                            quotes
  13:78  error  Strings must use singlequote                            quotes
  14:1   error  Expected indentation of 2 spaces but found 4            indent
  14:6   error  Missing semicolon                                       semi

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/callbacks.mjs
   21:12   error  Strings must use singlequote                                  quotes
   21:42   error  Strings must use singlequote                                  quotes
  178:11   error  'scoreFuncURL' is assigned a value but never used             no-unused-vars
  178:38   error  Strings must use singlequote                                  quotes
  178:46   error  Strings must use singlequote                                  quotes
  180:9    error  'scoreFunc' is defined but never used                         no-unused-vars
  225:15   error  Strings must use singlequote                                  quotes
  228:38   error  Strings must use singlequote                                  quotes
  228:46   error  Strings must use singlequote                                  quotes
  230:1    error  More than 1 blank line not allowed                            no-multiple-empty-lines
  233:7    error  Expected exception block, space or tab after '//' in comment  spaced-comment
  234:44   error  Missing semicolon                                             semi
  235:7    error  Expected exception block, space or tab after '//' in comment  spaced-comment
  236:26   error  Unexpected parentheses around single function argument        arrow-parens
  236:26   error  'responses' is defined but never used                         no-unused-vars
  236:40   error  eval can be harmful                                           no-eval
  236:135  error  Missing semicolon                                             semi
  237:7    error  Expected exception block, space or tab after '//' in comment  spaced-comment
  239:19   error  Unexpected string concatenation                               prefer-template
  239:19   error  Strings must use singlequote                                  quotes
  241:11   error  'TVScores' is never reassigned. Use 'const' instead           prefer-const
  241:32   error  Strings must use singlequote                                  quotes
  243:17   error  Strings must use singlequote                                  quotes
  243:39   error  Block must not be padded by blank lines                       padded-blocks
  246:19   error  Unexpected string concatenation                               prefer-template
  246:19   error  Strings must use singlequote                                  quotes
  247:6    error  Block must not be padded by blank lines                       padded-blocks
  249:1    error  Trailing spaces not allowed                                   no-trailing-spaces
  249:1    error  More than 1 blank line not allowed                            no-multiple-empty-lines

✖ 36 problems (36 errors, 0 warnings)
  32 errors and 0 warnings potentially fixable with the '--fix' option.
github-actions[bot] commented 1 year ago
/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/Surveys/team_viability.jsx
  12:1   error  Expected indentation of 2 spaces but found 4            indent
  12:5   error  Expected space(s) after "return"                        keyword-spacing
  13:9   error  Expected indentation of 6 space characters but found 8  react/jsx-indent
  13:45  error  Strings must use singlequote                            quotes
  13:78  error  Strings must use singlequote                            quotes
  14:1   error  Expected indentation of 2 spaces but found 4            indent
  14:6   error  Missing semicolon                                       semi

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/callbacks.mjs
  178:11  error  'scoreFuncURL' is assigned a value but never used  no-unused-vars
  180:9   error  'scoreFunc' is defined but never used              no-unused-vars
  235:25  error  'responses' is defined but never used              no-unused-vars
  235:38  error  eval can be harmful                                no-eval

✖ 11 problems (11 errors, 0 warnings)
  7 errors and 0 warnings potentially fixable with the '--fix' option.
github-actions[bot] commented 1 year ago
/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/SurveyWrapper.jsx
  17:28  error  The Function constructor is eval  no-new-func

✖ 1 problem (1 error, 0 warnings)
JamesPHoughton commented 1 year ago

@Alan-Qiao is the code in this PR included in your other PRs? Should we close it in favor of one of the others?

Alan-Qiao commented 1 year ago

Yes I've merged this into exitsurvey-list

JamesPHoughton commented 1 year ago

Thanks. Closing this in favor of https://github.com/Watts-Lab/deliberation-empirica/pull/263#issuecomment-1207232390