Watts-Lab / deliberation-empirica

Empirica V2 framework
MIT License
6 stars 0 forks source link

The "Submit" button element should be able to take button text as an argument #436

Closed JamesPHoughton closed 1 year ago

JamesPHoughton commented 1 year ago

Currently I believe the button just says "Next". We should be able to override this default in the treatment definition to make it say things like "I'm ready", etc. Should be a pretty easy fix.

For example, say that the treatment file has this syntax:

          - type: submitButton
            buttonText: Continue with experiment
            displayTime: 1590

Implementing notes:

Testing

Update the test to check that this works

JamesPHoughton commented 1 year ago

Ready to review the PR!

mxumary commented 1 year ago

PR here https://github.com/Watts-Lab/deliberation-empirica/pull/481

JamesPHoughton commented 1 year ago

Complete in https://github.com/Watts-Lab/deliberation-empirica/pull/481