Watts-Lab / deliberation-empirica

Empirica V2 framework
MIT License
5 stars 0 forks source link

`reference` syntax #811

Open JamesPHoughton opened 1 month ago

cypress[bot] commented 1 month ago

1 failed test on run #1397 ↗︎

1 15 1 0 Flakiness 0

Details:

Merge remote-tracking branch 'origin/main' into james-small-fixes
Project: Deliberation Commit: 5660979633
Status: Failed Duration: 12:01 💡
Started: May 14, 2024 6:21 PM Ended: May 14, 2024 6:33 PM
Failed  e2e/13_Constrained_Assignment.js • 1 failed test View Output
Test Artifacts
Constrained Assignment > assigns players to the correct games Screenshots

Review all test suite changes for PR #811 ↗︎

github-actions[bot] commented 1 week ago
/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/Game.jsx
  20:9  error  'timer' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/HairCheck.jsx
  100:9  warning  Unexpected alert                                                                                                                                                                                                                                                               no-alert
  115:6  warning  React Hook useEffect has missing dependencies: 'dailyObject', 'mountListeners', 'player', 'refreshDeviceList', and 'roomUrl'. Either include them or remove the dependency array                                                                                               react-hooks/exhaustive-deps
  123:6  warning  React Hook useEffect has a missing dependency: 'onVideoSuccess'. Either include it or remove the dependency array. If 'onVideoSuccess' changes too often, find the parent component that defines it and wrap that definition in useCallback                                    react-hooks/exhaustive-deps
  144:6  warning  React Hook useEffect has missing dependencies: 'audioSuccess', 'fftArray', and 'onAudioSuccess'. Either include them or remove the dependency array. If 'onAudioSuccess' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/Layouts.jsx
   13:19  error  'useReferenceValue' is defined but never used                                                          no-unused-vars
   37:45  error  Unexpected block statement surrounding arrow body; move the returned value immediately after the '=>'  arrow-body-style
   49:9   error  'passTimeCheck' is assigned a value but never used                                                     no-unused-vars
   49:25  error  'useTimeCheck' is not defined                                                                          no-undef
   50:9   error  'passPositionCheck' is assigned a value but never used                                                 no-unused-vars
   50:29  error  'usePositionCheck' is not defined                                                                      no-undef
   55:9   error  'timer' is assigned a value but never used                                                             no-unused-vars
  145:13  error  'responses' is assigned a value but never used                                                         no-unused-vars
  165:37  error  'timeCheck' is not defined                                                                             no-undef
  166:50  error  'positionCheck' is not defined                                                                         no-undef

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/Markdown.jsx
  17:6  error  Unnecessary escape character: !  no-useless-escape

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/SharedNotepad.jsx
  26:6  warning  React Hook useEffect has missing dependencies: 'defaultText', 'game', and 'record'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/TextChat.jsx
   72:6  warning  React Hook useEffect has a missing dependency: 'msgs.length'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
  183:7  warning  Unexpected alert                                                                                                no-alert

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/Qualtrics.jsx
  37:10  error  'state' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/Survey.jsx
  16:6  warning  React Hook useEffect has missing dependencies: 'progressLabel' and 'surveyName'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/TrainingVideo.jsx
  47:6  warning  React Hook useEffect has missing dependencies: 'timer?.elapsed' and 'url'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/Consent.jsx
  123:6  warning  React Hook useEffect has a missing dependency: 'player'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/Countdown.jsx
  8:21  error  Use default import syntax to import 'ReactCountdown'  import/no-named-default

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/NoGames.jsx
  20:18  error  React Hook "usePlayer" is called in function "message" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter. React Hook names must start with the word "use"  react-hooks/rules-of-hooks

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/PreIdChecks.jsx
  16:6  warning  React Hook useEffect has a missing dependency: 'setChecksPassed'. Either include it or remove the dependency array. If 'setChecksPassed' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/e2e/01_Normal_Paths_Omnibus.js
  168:34  error  'actualOrder' is already declared in the upper scope on line 149 column 13  no-shadow

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/support/sharedSteps.js
  10:11  error  'log' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/index.js
  42:43  error  'p' is defined but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/preFlight/dispatch.js
  524:9  error  Unexpected use of continue statement  no-continue

✖ 30 problems (19 errors, 11 warnings)
  1 error and 0 warnings potentially fixable with the '--fix' option.
github-actions[bot] commented 4 days ago
/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/Game.jsx
  20:9  error  'timer' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/HairCheck.jsx
  100:9  warning  Unexpected alert                                                                                                                                                                                                                                                               no-alert
  115:6  warning  React Hook useEffect has missing dependencies: 'dailyObject', 'mountListeners', 'player', 'refreshDeviceList', and 'roomUrl'. Either include them or remove the dependency array                                                                                               react-hooks/exhaustive-deps
  123:6  warning  React Hook useEffect has a missing dependency: 'onVideoSuccess'. Either include it or remove the dependency array. If 'onVideoSuccess' changes too often, find the parent component that defines it and wrap that definition in useCallback                                    react-hooks/exhaustive-deps
  144:6  warning  React Hook useEffect has missing dependencies: 'audioSuccess', 'fftArray', and 'onAudioSuccess'. Either include them or remove the dependency array. If 'onAudioSuccess' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/Markdown.jsx
  17:6  error  Unnecessary escape character: !  no-useless-escape

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/SharedNotepad.jsx
  26:6  warning  React Hook useEffect has missing dependencies: 'defaultText', 'game', and 'record'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/TextChat.jsx
   72:6  warning  React Hook useEffect has a missing dependency: 'msgs.length'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
  183:7  warning  Unexpected alert                                                                                                no-alert

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/Qualtrics.jsx
  37:10  error  'state' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/Survey.jsx
  16:6  warning  React Hook useEffect has missing dependencies: 'progressLabel' and 'surveyName'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/TrainingVideo.jsx
  47:6  warning  React Hook useEffect has missing dependencies: 'timer?.elapsed' and 'url'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/Consent.jsx
  123:6  warning  React Hook useEffect has a missing dependency: 'player'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/Countdown.jsx
  8:21  error  Use default import syntax to import 'ReactCountdown'  import/no-named-default

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/NoGames.jsx
  20:18  error  React Hook "usePlayer" is called in function "message" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter. React Hook names must start with the word "use"  react-hooks/rules-of-hooks

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/PreIdChecks.jsx
  16:6  warning  React Hook useEffect has a missing dependency: 'setChecksPassed'. Either include it or remove the dependency array. If 'setChecksPassed' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/e2e/01_Normal_Paths_Omnibus.js
  168:34  error  'actualOrder' is already declared in the upper scope on line 149 column 13  no-shadow

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/support/sharedSteps.js
  10:11  error  'log' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/index.js
  42:43  error  'p' is defined but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/preFlight/dispatch.js
  524:9  error  Unexpected use of continue statement  no-continue

✖ 20 problems (9 errors, 11 warnings)