Watts-Lab / deliberation-empirica

Empirica V2 framework
MIT License
5 stars 0 forks source link

Condition on player being assigned to a game #826

Closed JamesPHoughton closed 3 weeks ago

github-actions[bot] commented 3 weeks ago
/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/Game.jsx
  20:9  error  'timer' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/HairCheck.jsx
  100:9  warning  Unexpected alert                                                                                                                                                                                                                                                               no-alert
  115:6  warning  React Hook useEffect has missing dependencies: 'dailyObject', 'mountListeners', 'player', 'refreshDeviceList', and 'roomUrl'. Either include them or remove the dependency array                                                                                               react-hooks/exhaustive-deps
  123:6  warning  React Hook useEffect has a missing dependency: 'onVideoSuccess'. Either include it or remove the dependency array. If 'onVideoSuccess' changes too often, find the parent component that defines it and wrap that definition in useCallback                                    react-hooks/exhaustive-deps
  144:6  warning  React Hook useEffect has missing dependencies: 'audioSuccess', 'fftArray', and 'onAudioSuccess'. Either include them or remove the dependency array. If 'onAudioSuccess' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/Markdown.jsx
  17:6  error  Unnecessary escape character: !  no-useless-escape

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/SharedNotepad.jsx
  26:6  warning  React Hook useEffect has missing dependencies: 'defaultText', 'game', and 'record'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/TextChat.jsx
   72:6  warning  React Hook useEffect has a missing dependency: 'msgs.length'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
  183:7  warning  Unexpected alert                                                                                                no-alert

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/VideoCall.jsx
  159:10  error  'state' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/Qualtrics.jsx
  37:10  error  'state' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/Survey.jsx
  15:6  warning  React Hook useEffect has missing dependencies: 'progressLabel' and 'surveyName'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/TrainingVideo.jsx
  47:6  warning  React Hook useEffect has missing dependencies: 'timer?.elapsed' and 'url'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/Consent.jsx
  119:6  warning  React Hook useEffect has a missing dependency: 'player'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/Countdown.jsx
  8:21  error  Use default import syntax to import 'ReactCountdown'  import/no-named-default

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/IdForm.jsx
  29:6  warning  React Hook useEffect has a missing dependency: 'setChecksPassed'. Either include it or remove the dependency array. If 'setChecksPassed' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/NoGames.jsx
  20:18  error  React Hook "usePlayer" is called in function "message" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter. React Hook names must start with the word "use"  react-hooks/rules-of-hooks

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/e2e/01_Normal_Paths_Omnibus.js
  149:34  error  'actualOrder' is already declared in the upper scope on line 130 column 13  no-shadow

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/support/sharedSteps.js
  10:11  error  'log' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/index.js
  42:43  error  'p' is defined but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/preFlight/dispatch.js
  521:9  error  Unexpected use of continue statement  no-continue

✖ 21 problems (10 errors, 11 warnings)
cypress[bot] commented 3 weeks ago

Passing run #1370 ↗︎

0 16 1 0 Flakiness 0

Details:

Merge branch 'main' into james-debug-errors
Project: Deliberation Commit: 53271c0b85
Status: Passed Duration: 09:47 💡
Started: Apr 24, 2024 12:36 PM Ended: Apr 24, 2024 12:46 PM

Review all test suite changes for PR #826 ↗︎

github-actions[bot] commented 3 weeks ago
/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/Game.jsx
  20:9  error  'timer' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/HairCheck.jsx
  100:9  warning  Unexpected alert                                                                                                                                                                                                                                                               no-alert
  115:6  warning  React Hook useEffect has missing dependencies: 'dailyObject', 'mountListeners', 'player', 'refreshDeviceList', and 'roomUrl'. Either include them or remove the dependency array                                                                                               react-hooks/exhaustive-deps
  123:6  warning  React Hook useEffect has a missing dependency: 'onVideoSuccess'. Either include it or remove the dependency array. If 'onVideoSuccess' changes too often, find the parent component that defines it and wrap that definition in useCallback                                    react-hooks/exhaustive-deps
  144:6  warning  React Hook useEffect has missing dependencies: 'audioSuccess', 'fftArray', and 'onAudioSuccess'. Either include them or remove the dependency array. If 'onAudioSuccess' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/Markdown.jsx
  17:6  error  Unnecessary escape character: !  no-useless-escape

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/SharedNotepad.jsx
  26:6  warning  React Hook useEffect has missing dependencies: 'defaultText', 'game', and 'record'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/TextChat.jsx
   72:6  warning  React Hook useEffect has a missing dependency: 'msgs.length'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
  183:7  warning  Unexpected alert                                                                                                no-alert

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/VideoCall.jsx
  159:10  error  'state' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/Qualtrics.jsx
  37:10  error  'state' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/Survey.jsx
  15:6  warning  React Hook useEffect has missing dependencies: 'progressLabel' and 'surveyName'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/TrainingVideo.jsx
  47:6  warning  React Hook useEffect has missing dependencies: 'timer?.elapsed' and 'url'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/Consent.jsx
  119:6  warning  React Hook useEffect has a missing dependency: 'player'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/Countdown.jsx
  8:21  error  Use default import syntax to import 'ReactCountdown'  import/no-named-default

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/IdForm.jsx
  29:6  warning  React Hook useEffect has a missing dependency: 'setChecksPassed'. Either include it or remove the dependency array. If 'setChecksPassed' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/NoGames.jsx
  20:18  error  React Hook "usePlayer" is called in function "message" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter. React Hook names must start with the word "use"  react-hooks/rules-of-hooks

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/e2e/01_Normal_Paths_Omnibus.js
  149:34  error  'actualOrder' is already declared in the upper scope on line 130 column 13  no-shadow

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/support/sharedSteps.js
  10:11  error  'log' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/index.js
  42:43  error  'p' is defined but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/preFlight/dispatch.js
  521:9  error  Unexpected use of continue statement  no-continue

✖ 21 problems (10 errors, 11 warnings)