Watts-Lab / surveys

Library of surveys for deliberation experiments
MIT License
3 stars 4 forks source link

fixed moz thumb #132

Closed gumillie222 closed 1 year ago

cypress[bot] commented 1 year ago

Passing run #182 ↗︎

0 180 0 0 Flakiness 0

Details:

turn off headless testing
Project: Surveys Commit: 96a08065c6
Status: Passed Duration: 10:09 💡
Started: Jul 27, 2023 8:06 PM Ended: Jul 27, 2023 8:16 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

cypress[bot] commented 1 year ago

7 failed tests on run #164 ↗︎

7 33 0 0 Flakiness 0

Details:

Merge d68d9f5d303def8005bc6e9988faa87dbcb35123 into 61476b678f93796d7917f3375b59...
Project: Surveys Commit: 11fa260480 ℹ️
Status: Failed Duration: 03:06 💡
Started: Jun 25, 2023 7:07 PM Ended: Jun 25, 2023 7:10 PM
Failed  src/surveyFactory.cy.jsx • 1 failed test • Firefox browser tests View Output Video
Test Artifacts
SurveyFactory > stores intermediate results Output Screenshots
Failed  surveys/demographics/demographics.cy.jsx • 1 failed test • Firefox browser tests View Output Video
Test Artifacts
Demographics > completes Output Screenshots
Failed  surveys/discussionQualityControl/discussionQualityControl.cy.jsx • 1 failed test • Firefox browser tests View Output Video
Test Artifacts
Demographics > completes Output Screenshots
Failed  surveys/exampleSurvey/exampleSurvey.cy.jsx • 1 failed test • Firefox browser tests View Output Video
Test Artifacts
ExampleSurvey > completes Output Screenshots
Failed  surveys/politicalPartyUS/politicalPartyUS.cy.jsx • 1 failed test • Firefox browser tests View Output Video
Test Artifacts
PoliticaPartyUS > completesOther Output Screenshots

The first 5 failed specs are shown, see all 7 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

JamesPHoughton commented 1 year ago

Todo: Set up GH actions to run the tests in both chrome and firefox (and maybe edge?)

JamesPHoughton commented 1 year ago

@gumillie222 - tests are failing for me locally and on github - would you mind revisiting this?

gumillie222 commented 1 year ago

on my local end cypress tests are all passing now!

JamesPHoughton commented 1 year ago

@gumillie222 still having some errors of the CI - have I shown you how to use the cypress cloud interface to look at CI tests? might be a good idea to sit down with @kepstein23 and work those ones out together, if you get a chance.

gumillie222 commented 1 year ago

@JamesPHoughton I don't think we did. @kepstein23 Would tomorrow's co-working session work for you?

kepstein23 commented 1 year ago

@gumillie222 yes, we can work tomorrow!

gumillie222 commented 1 year ago

Most of the tests failing are on Firefox and on cypress cloud specifically (all tests ran successfully on local cypress). Kimberly and I worked on this for a while. Here is a particular issue:

Screenshot 2023-06-29 at 11 33 23 PM Screenshot 2023-06-29 at 11 32 22 PM

The last test is failing on cypress cloud, issue being openResponse not being stored properly. All the ones before passed, including the one testing if the text is being entered into the text box. We suspect that it's an issue with how cypress cloud handles local storage, and it's weird because the other 2 values are being stored and read. We can't find enough helpful resource on this, so @JamesPHoughton, might need your help!

kepstein23 commented 1 year ago

Most of the tests failing are on Firefox and on cypress cloud specifically (all tests ran successfully on local cypress). Kimberly and I worked on this for a while. Here is a particular issue:

Screenshot 2023-06-29 at 11 33 23 PM Screenshot 2023-06-29 at 11 32 22 PM The last test is failing on cypress cloud, issue being openResponse not being stored properly. All the ones before passed, including the one testing if the text is being entered into the text box. We suspect that it's an issue with how cypress cloud handles local storage, and it's weird because the other 2 values are being stored and read. We can't find enough helpful resource on this, so @JamesPHoughton, might need your help!

Would also like to add that we tried asserting that the textarea's value is updated, which passes locally and in CI, and we tried adding a wait statement which didn't help. This led us to believe that there's an issue with the text area's value not being saved to localStorage in the cloud. Also, notably, this is only happening in Firefox on the CI and is not happening in firefox or Electron locally.

JamesPHoughton commented 1 year ago

Tests all run successfully on local...