Watts-Lab / team-process-map

MIT License
0 stars 4 forks source link

Named Entity Recognition + Valence Tests #226

Open agshruti12 opened 1 month ago

agshruti12 commented 1 month ago

Pull Request Template: If you are merging in a feature or other major change, use this template to check your pull request!

Basic Info

What's this pull request about?

Tests for NER and valence. NER tests are a modified unit test, checking correct NUMBER of named entities, along with correct named entities themselves. Has it's own test dataset called 'test_named_entity.csv'. Performed valence testing as well using perturbation framework. For a given positive/negative sentence, have generated a corresponding INV and DIR perturbed sentence. Test checks to see if the magnitude of the DIR change is greater than the magnitude of the INV change. Has it's own test dataset called test_chat_level_complex.csv. We can input more tests that operated with the perturbation framework at the chat level in this csv.

Feature Documentation

Did you document your feature? Make sure you do the following before you pull request!

Code Basics

Testing

The location of my tests are here:

[PASTE LINK HERE]

If you check all the boxes above, then you ready to merge!

xehu commented 1 month ago

I notice that not all the NER tests pass --- but this is because the feature isn't perfect! Would it be possible to run the feature on the full test dataset in order to get metrics (e.g., precision/recall), but then only run the test on a subset of the NER features that we know are supposed to work? That way, we won't have all the tests return as 'failing' ...