search

WayScience / coSMicQC

Single cell Morphology Quality Control (coSMicQC)
https://wayscience.github.io/coSMicQC/
BSD 3-Clause "New" or "Revised" License
7 stars 3 forks source link

Enhance report capabilities #43

Closed d33bs closed 2 weeks ago

d33bs commented 5 months ago

Some comments/suggestions for the future:

  1. It could be useful to show the distributions of the individual feature spaces with the option to show the z-scores. It might be easier for someone to interpret, given the feature space.
  2. Might recommend having different colors per condition section.
  3. It is sometimes hard to see the differences between inlier and outlier.

_Originally posted by @jenna-tomkinson in https://github.com/WayScience/coSMicQC/pull/39#discussion_r1659363675_

d33bs commented 5 months ago

From #39 https://github.com/WayScience/coSMicQC/pull/39#discussion_r1659968861

Thanks for these thoughts! Will create a new issue to capture these thoughts for future revision. Generally I think 1. is a great idea but may require further tinkering of the parameter options for reporting. Perhaps this could be delineated by "histogram" vs "feature space" report types. For 2.: the report colors in testing only include 2 colors to help keep the report output the same each time (avoiding git from detecting changes when it runs, or showing changes as they occur) - when it runs as normal the colors will be as displayed in the description (random selections from Plotly's Dark2 palette). For 3. I wasn't sure of how to do this in the best way without making the outliers appear "too" much, will experiment with you on this further later.

d33bs commented 2 weeks ago

show_report was removed during the migration of CytoDataFrame and has also been removed from that project. Closing this issue as a result.