`label_outliers` error - Githubissues

WayScience / coSMicQC

Single cell Morphology Quality Control (coSMicQC)

https://wayscience.github.io/coSMicQC/

BSD 3-Clause "New" or "Revised" License

7 stars 3 forks source link

`label_outliers` error #70

Closed jenna-tomkinson closed 2 weeks ago

jenna-tomkinson commented 3 months ago

Is this a duplicate of an existing idea for this project?

[X] I found no existing issues covering this topic.

What is your idea?

When trying to import label_outliers from coSMicQC or just access the function by using cosmicqc.label_outliers, I am getting an ImportError and AttributeError.

From my understanding, this could be due to the __init__.py not including the function. Would this be the correct solution?

Would you like to work on a solution for this?

[X] Yes I am willing to submit a PR for this!

d33bs commented 3 months ago

@jenna-tomkinson - double checking, do you think this is able to be closed after the merge of #71? Cheers on the fix!

Aside, if you ever want to close the issue with a PR you can use the special keyword "closes" followed by the numbered reference to close the issue when the PR is merged. See here for more information.

jenna-tomkinson commented 3 months ago

Oh my bad! Also that is a super cool thing I didn't know existed haha!

Yes this should be able to be closed, but would we be able to test this in the next release or can we test now?

d33bs commented 2 weeks ago

Closing this as per comments from @jenna-tomkinson (thanks Jenna!). This should be testable and if it's still a problem let's re-raise and address in a new issue.