search

WayScience / phenotypic_profiling

Machine learning for predicting 15 single-cell phenotypes from cell morphology profiles
Creative Commons Attribution 4.0 International
2 stars 3 forks source link

Refactor evaluate module #21

Closed roshankern closed 1 year ago

roshankern commented 1 year ago

This PR is ready for review!

In this PR, the evaluate module is reformatted to include evaluations for each model (final, shuffled baseline) trained with each feature type (CP, DP, CP_and_DP) on each dataset (train, test, etc). For most of these functions, this means simply loading in the correct feature dataset with get_X_y_data().

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

roshankern commented 1 year ago

Although this PR looks huge, most line changes are from changes in intermediate files. There are about 150 lines of code changed in this PR.

review-notebook-app[bot] commented 1 year ago

View / edit / reply to this conversation on ReviewNB

axiomcura commented on 2023-03-22T20:03:19Z ----------------------------------------------------------------

Line #8.    for model_path in sorted(models_dir.iterdir()):

Should the users know why the directories were sorted?


roshankern commented 1 year ago

Thank you both for the review! @axiomcura your suggestions have been implemented in https://github.com/WayScience/phenotypic_profiling_model/pull/21/commits/1f311922a03200cdcfa74a54e9d9c2048d64d1f1

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.