Closed gwaybio closed 1 year ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Feature space | Number of top scoring phenotypes |
---|---|
CP_and_DPtest | 10 |
CPtest | 4 |
DPtest | 2 |
@roshankern - I also had a question: what is Weighted
? Should I include this class in the F1 score bar chart?
@roshankern - I also had a question: what is
Weighted
? Should I include this class in the F1 score bar chart?
Weighted
refers to the weighted F1 score (the mean F1 score that takes into account occurrences of each label). I think this is good to include as it gives an idea of the overall performance of the model.
Another small comment: consider changing the final pr curve figure to 3 rows x 5 comments instead of 4x4 format. I think this would look better for a final figure, especially since there are 15 models. This is nitpicky, so feel free to ignore.
There might be something to address in this PR now that the threshold values changed for multiclass models in #26.
Another small comment: consider changing the final pr curve figure to 3 rows x 5 comments instead of 4x4 format. I think this would look better for a final figure, especially since there are 15 models. This is nitpicky, so feel free to ignore.
This is a very good suggestion.
I've also implemented all other suggestions, I am going to merge!
Weighted refers to the weighted F1 score (the mean F1 score that takes into account occurrences of each label). I think this is good to include as it gives an idea of the overall performance of the model.
One last thing - i changed this label to increase clarity
Also adding CP+DP features and the F1 score notebook