WayScience / phenotypic_profiling

Machine learning for predicting 15 single-cell phenotypes from cell morphology profiles

Creative Commons Attribution 4.0 International

2 stars 3 forks source link

Add models with no-ic [training and LOIO] #51

Closed gwaybio closed 9 months ago

gwaybio commented 9 months ago

@roshankern can you review my contributions (the last two commits), and I will review your contributions (first two commits).

My plan is to get this merged in, address comments in #47, merge #47, and then start a new visualization with a clean repo.

I looked at the results briefly, and they don't seem to be changed much (i.e. IC doesn't seem to have a big impact in this case).

review-notebook-app[bot] commented 9 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

gwaybio commented 9 months ago

I would recommend waiting to merge this until after we merge https://github.com/WayScience/mitocheck_data/pull/37 and integrate the new download link so we don't have an unclear download path on main.

Sounds good, thanks @roshankern ! Please give me a 👍 when I can merge. (I will also fix your file name comment ASAP).

roshankern commented 9 months ago

Sounds good, thanks @roshankern ! Please give me a 👍 when I can merge. (I will also fix your file name comment ASAP).

Will do!

gwaybio commented 9 months ago

37 looks great @roshankern, I just reviewed. I think there is one small change to do.

I also addressed the file name fix you suggested above. Once you merge in #37 feel free to merge this one.