WayScience / phenotypic_profiling

Machine learning for predicting 15 single-cell phenotypes from cell morphology profiles
Creative Commons Attribution 4.0 International
1 stars 3 forks source link

Add Figure 1 #57

Closed jenna-tomkinson closed 7 months ago

jenna-tomkinson commented 7 months ago

Add Figure 1

In this PR, figure 1 for the manuscript has been created in R using patchwork. Panel A is generated in the notebook, and Panel B is created in BioRender and saved as PNG.

review-notebook-app[bot] commented 7 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

gwaybio commented 7 months ago

It's a really nice figure! 🎉

Here are a couple nitpicks:

Panel A

Panel B

General

Happy to give this another look after the second iteration!

jenna-tomkinson commented 7 months ago

Here is what I have implemented based on your review:

Panel A

  1. Increased text size (please let me know if these need to be increased more)
  2. Changed capitalization to keep consistent but didn't change the x-axis title due to this statement: "The mitocheck phenotype classes themselves do not need to be changed!". Let me know if I misinterpreted this and I will also update this title too for capitalization.
  3. I changed to the Dark2 palette from RColorBrewer. I think it clashes less, but please let me know if this should be changed as well. Here is also the link to the different palettes if you see one that would be better: https://r-graph-gallery.com/38-rcolorbrewers-palettes.html.

Panel B (likely will need font increased)

  1. Updated to use consistent capitalization
  2. Matched colors for CP, DP, and Both
  3. Fixed plate map
  4. Removed text from normalization example figure
  5. Updated normalization statement
  6. Updated Machine learning plot
  7. Tried to improve the generalizability section, just struggling with how to simply visualize what we need. This definitely still needs work so in your next review I would love more suggestions.

General

Made the tags much bigger and fixed the alignment issue/whitespace issue by making the plot "free" per the documentation to avoid patchwork from trying to align itself.

I look forward to more improvements after your next review!

gwaybio commented 7 months ago

More nitpicks:

Panel A

Panel B

jenna-tomkinson commented 7 months ago

main_figure_1_class_count_and_workflow(1)

Figure 1: Class counts and workflow

jenna-tomkinson commented 7 months ago

@gwaybio Thank you lots for the review! This was a great first exercise with patchwork and I am excited to work more on creating figures! I will be merging now after addressing your comments, but please feel free to let me know if anything else needs to be updated.