search

WayfireWM / wayfire

A modular and extensible wayland compositor
https://wayfire.org/
MIT License
2.42k stars 179 forks source link

Add IPC event for switching TTYs #2476

Closed mark-herbert42 closed 1 month ago

mark-herbert42 commented 1 month ago

I use light command to change brtightness mapped to a keyboard shortcuts. So it works.

But when I switch to text console (Alt-F) and back - the screen is much brighter. But when I run light to show the brightness - it shows the same as before switch. So switching to console and back causes the hardware to go to higher brightness level somehow, and it is not restored.

Not sure if it is afeature or a bug and what but it is , and is it possible to have a workaround to call save and restore brightness when switching between text console and wayfire session?

ammen99 commented 1 month ago

Wayfire does not control brightness in any way, but I suppose we could add an IPC event for when switching between TTYs and then you can store/restore brightness with a script.

mark-herbert42 commented 1 month ago

same story happens when returning from "dpms" state that entered with idle plugin. Screen goes to sleep from dim night mode but when touch mouse it wakes up bright. And again light program does not see the brtightness change but it happens somewhere deep in hardware.

mark-herbert42 commented 1 month ago

Looks like it is an amdgpu issue - opened the bug with them. I've tried same actions on other laptop which s Intel based and no issue with brightness at all. Still if there is a way to set up IPC on [oint when the wayfire screen lights up - on wayfire start, waking up from idle or returning back from text console switching TTY that could be a way to workaround this

soreau commented 1 month ago

Wayfire could tie into wlr_session->events.active but in my experience, this can be unreliable do to a possible seatd bug.

mark-herbert42 commented 1 month ago

The resolution of the bug is clear and is inside AMD kernel driver. Not yet done and maybe never will be as the code is pretty long ago in the kernel and was not reported before. The buggy "feature" was introduced to workaround some mini-led HDR panels but somehow was applied to amoled as well where it is absolutely not required.

Here is the link to amdgpu gitlab where I posted the patch reverting miniled workaround, but of course that can not be applied to mainstream as it will cause big issues for miniled.

https://gitlab.freedesktop.org/drm/amd/-/issues/3655

ammen99 commented 1 month ago

I guess we won't be adding more IPC events until we find a good use-case for them.

Thanks for updating this issue :)