WayfireWM / wf-config

A library for managing configuration files, written for wayfire
https://wayfire.org/
MIT License
18 stars 19 forks source link

Support lists in /etc/wayfire/defaults.ini #30

Closed AdrianVovk closed 1 year ago

AdrianVovk commented 4 years ago

Title explains it. Right now, lists are ignored from that config file

Also, there needs to be a way for items to be added to the list in ~/.config/wayfire.ini without disrupting the items in /etc (for example, I can have a default list of plugins in /etc and then optionally load in stuff like cube in ~)

ammen99 commented 4 years ago

Title explains it. Right now, lists are ignored from that config file

Also, there needs to be a way for items to be added to the list in ~/.config/wayfire.ini without disrupting the items in /etc (for example, I can have a default list of plugins in /etc and then optionally load in stuff like cube in ~)

I don't like this particular thing, goes against wayfire's philosophy. I think it would be better to have two separate lists of plugins (plugins_system and plugins_user) on the Wayfire side. Both will be overwritable by users, but for ex. you can set the one globally the one and let users use the other. That should be enough for you I hope?

List support in general are useful, that will definitely be implemented eventually.

AdrianVovk commented 4 years ago

@ammen99 Yeah that's the solution I mentioned in IRC. As long as users won't be nuking my config unless they really mean to I'm happy with it 👍

Maybe the options should be plugins and global_plugins or dist_plugins?

AdrianVovk commented 4 years ago

Just a note I know plugins isn't a real "list" type right now, but stuff like autostart and command should behave the same way (I can set a global autostart script, and users can add things to their own autostart, and I guess if they want they can override mine)

ammen99 commented 1 year ago

For future reference: I believe in fact the best way for this to happen is simply a custom config backend for Wayfire, which can take the options from whichever files it needs to.