WayfireWM / wf-osk

A very, very basic on-screen keyboard using gtkmm, virtual-keyboard-v1 and layer-shell protocols
MIT License
26 stars 4 forks source link

added a special 'pinned' anchor. #3

Closed gg-rewrite closed 4 years ago

gg-rewrite commented 4 years ago

Added a special anchor ("pinned") to be able to push windows from below the keyboard and position it at the bottom of the screen.

No special window resize code is needed as the width of the keyboard's window is set automatically by the compositor in exlusive zone mode.

ammen99 commented 4 years ago

I don't like the way -2 is used as a magic constant, can you define it and then use it with its name? Maybe static constexpr int32_t anchor_pinned_bottom = -2;

gg-rewrite commented 4 years ago

And done cc69a0388423493f82f3ca8887f75442dbcb0426.

ammen99 commented 4 years ago

Thanks, all seems good now!