wf-dock doesn't display some icons

WayfireWM / wf-shell

A GTK3-based panel for wayfire

https://wayfire.org/

MIT License

138 stars 35 forks source link

wf-dock doesn't display some icons #93

Open ghost opened 3 years ago

ghost commented 3 years ago

Describe the bug A clear and concise description of what the bug is. xwayland icons don't get displayed some native ones too (though I don't know if they have one 100%)

To Reproduce Steps to reproduce the behavior:

Enable wf-dock
some applications don't have icons when they should

Expected behavior A clear and concise description of what you expected to happen. have icon

Screenshots or stacktrace

Backtrace with address sanitizer enabled (if possible):

Wayfire version aur/wayfire 0.7.1-3 (+16 1.02) (Installed) 3D wayland compositor

ammen99 commented 3 years ago

This is probably because these apps do not have the correct .desktop file entries and/or do not report their correct app_id.

ghost commented 3 years ago

yeah, I can't test if its the same on other desktop enviroments because they kick me back to the greeter, you could though but i remember gimp having an icon

florhizome commented 3 years ago

I have this issue, too, for various apps, and for themeing - gtkthemes are not going to be found f.e. It might moreso be the case that wayfire, when started without a surrounding DE (which are probably most usecases rn, doesn't set important env variables) These are the only XDG variables that are set for me in my wayfire session. notably XDG_DATA_HOME where icon themes and fonts are mostly stored is not set. GTK f.e. relies on those for it's data.