Wayne0117
commented
6 years ago Thank you - will definitely use comments when I continue practicing. Appreciate the feedback on the preso - wanted to hit all the points from the project request and didn't focus as much on how I would present this professionally.
Overall, this was a great project!
I won't have too much to say about your code, as all of your code was written cleanly and efficiently. All of your python code worked correctly towards accomplishing the various data science tasks. You followed many of the best conventions concerning indentation and variable naming conventions. This helped in making your python code easily readable. Here is more information on python styling conventions if you are interested.
I would suggest you practice adding in your own comments and a README to this github repository to give some context to your code. Comments answer questions like 'What were you thinking when you writing this code?' and 'What is the purpose of this chunk of code? Are there currently any issues with it?" Here is a helpful guide for creating READMEs that give a good introduction to your project.
On your presentation: I would suggest you introduce your project before you jump into your data and calculations. You should answer questions like, "What problem are you trying to solve?", "Why is this problem important?", "What information do you need to know about the problem?". This will help your audience feel more involved and engaged with your work. I was impressed with your clever presentation of the chi-square test results.
The table you made was clear and easy to parse for the results of your tests.