search

WayneD / script.tv.show.next.aired

Updated Next Aired addon for XBMC.
http://forum.xbmc.org/showthread.php?tid=186090
GNU General Public License v2.0
14 stars 20 forks source link

Fixed unicode issues #4

Closed roee88 closed 9 years ago

roee88 commented 9 years ago

Encoding to ascii with 'replace' fallback makes no sense for some languages. I.e. the script may search for empty strings due to this behavior.

WayneD commented 9 years ago

Removing the encode to ascii doesn't look right to me. We can drop the 'ignore' option, and that would make it either fully normalize the string to ascii or return the original string. I'm going to check that in and see if we can get some users to test the result.

roee88 commented 9 years ago

Why would you want to encode to ascii? If you want it as 8bit string use utf-8.

Edit: I'm not sure why but using latest master all shows show up in the addon itself but skin integration is broken for non-english tv show titles. Again, all works well if I just drop .encode("ascii") or use utf-8 instead (in the later case, line 552 should also be adjusted to avoid unicode issues).

tomer953 commented 8 years ago

Hey Wayne, I see this as a "must have" commit - the addon is not working with non English titles, can you please consider to merge it?

WayneD commented 8 years ago

Did you try out the beta zip file yet? http://opencoder.net/script.tv.show.next.aired.zip

The help thread mentions the link: http://forum.kodi.tv/showthread.php?tid=186090

tomer953 commented 8 years ago

Actually I did, and for some reason I don't get the skin properties. (I'm a skinner, I'm using this: Window(Home).Property(NextAired.Label) Window(Home).Property(NextAired.NextTitle) etc... ) take a look at that short vid please: https://vid.me/gGWT