WayneDW / DeepLight_Deep-Lightweight-Feature-Interactions

Accelerating Inference for Recommendation Systems (WSDM'21)
https://arxiv.org/abs/2002.06987
112 stars 23 forks source link

BugReport #6

Open RileyYe opened 2 years ago

RileyYe commented 2 years ago

Template class SparseMatrix is in namespace SparseMatrix. So for all SparseMatrix referred in criteo_latency.cpp, they should be revised to SparseMatrix::SparseMatrix, or using namespace SparseMatrix.

Also, the function cnt_time is not available, because of the failure of static type casting. The error can be eliminated if revise this function to

template <typename T>
double cnt_time(T start, T end) {
    auto diff = end - start;
    return chrono::duration <double, milli>(diff).count();
}

.

WayneDW commented 2 years ago

Hi, Riley, thanks for pointing out this issue. Since this link has not been updated for quite a while, I will leave your suggestion here to let others know.

Thanks a lot again.