search

WayneGitShell / GWSDAT

GroundWater Spatiotemporal Data Analysis Tool (GWSDAT) R-Shiny implementation.
https://stats-glasgow.shinyapps.io/GWSDAT
31 stars 7 forks source link

Commented out read.shape() because it does not resolve.. #162

Closed andrejadd closed 7 years ago

andrejadd commented 7 years ago

.. and it unlikely to be called

if(!is.null(formals(readShapeLines)$delete_null_obj)){
   res <- readShapeLines(fn = fn, proj4string = proj4string,verbose = verbose, repair = repair,delete_null_obj=delete_null_obj)
}else{
   res <- GWSDAT.readShapeLines(fn = fn, proj4string = proj4string,verbose = verbose, repair = repair)
}

Fct GWSDAT.readShapeLines() contains the call to read.shape(). It must have been exported in package 'sp' I guess, but nowadays its not found nowhere.

Since we will move to package 'sf' this will become obsolete anyway.

andrejadd commented 7 years ago

findFunction("read.shape") list()

Nothing there.