WayneGitShell / GWSDAT

GroundWater Spatiotemporal Data Analysis Tool (GWSDAT) R-Shiny implementation.
https://stats-glasgow.shinyapps.io/GWSDAT
31 stars 7 forks source link

Do I need substance specific dates? #176

Closed andrejadd closed 6 years ago

andrejadd commented 7 years ago

See:

Fitted.Data[[substance]]$Time.Eval vs. All.Data$All.Agg.Dates

In the first case, only dates exist when concentration is present. However, in the time-series of the spatial plot, we always take All.Data$All.Agg.Dates as basis (so the time slider does not change or jump, which is not a bad idea).

Are there other places we would need this or can I ditch it?

andrejadd commented 6 years ago

All dates are inside All.Data$All_Agg_Dates. Each substance references to this list.

I deleted Fitted.Data[[substance]]$Time.Eval because it was using All.Data$All_Agg_Dates anyways. I would have to take out the GW aggregation dates and make something like this:

get_sub_tbl <- All.Data$Cont.Data[All.Data$Cont.Data$Constituent == substance, ]
Fitted.Data[[substance]]$Time.Eval <- sort(unique(get_sub_tbl$AggDate))

Although, Fitted.Data is not the right place I believe. It should be kept just in a substance specific table.