WayneLambert / portfolio

Portfolio site demonstrating skills with Python, Django, JavaScript, HTML, Sass, PostgreSQL, pytest, Docker, and Git.
https://waynelambert.dev
6 stars 1 forks source link

Improve Longevity of Email Token Cryptography Solution #177

Closed WayneLambert closed 2 years ago

WayneLambert commented 2 years ago

Addresses the following:

Contributes towards: #107

sourcery-ai[bot] commented 2 years ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.62%.

Quality metrics Before After Change
Complexity 0.32 ⭐ 0.42 ⭐ 0.10 πŸ‘Ž
Method Length 49.51 ⭐ 48.31 ⭐ -1.20 πŸ‘
Working memory 7.25 πŸ™‚ 6.48 πŸ™‚ -0.77 πŸ‘
Quality 75.56% ⭐ 74.94% πŸ™‚ -0.62% πŸ‘Ž
Other metrics Before After Change
Lines 854 556 -298
Changed files Quality Before Quality After Quality Change
aa_project/settings/base.py 54.25% πŸ™‚ 54.24% πŸ™‚ -0.01% πŸ‘Ž
aa_project/settings/dev.py 88.36% ⭐ 88.68% ⭐ 0.32% πŸ‘
aa_project/settings/pytest/pytest.py 85.53% ⭐ 85.12% ⭐ -0.41% πŸ‘Ž
apps/users/models.py 90.82% ⭐ 90.82% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
apps/users/models.py EmailToken.save 2 ⭐ 46 ⭐ 11 😞 73.24% πŸ™‚ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The πŸ‘ and πŸ‘Ž indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

codecov[bot] commented 2 years ago

Codecov Report

Merging #177 (d913e87) into main (779674d) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #177   +/-   ##
=======================================
  Coverage   89.12%   89.12%           
=======================================
  Files          61       61           
  Lines        1618     1619    +1     
  Branches      199      199           
=======================================
+ Hits         1442     1443    +1     
  Misses        154      154           
  Partials       22       22           
Flag Coverage Ξ”
unittests 89.12% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
aa_project/settings/base.py 100.00% <100.00%> (ΓΈ)
apps/users/models.py 93.67% <100.00%> (ΓΈ)

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 779674d...d913e87. Read the comment docs.