Closed WayneLambert closed 2 years ago
β Merging this PR will decrease code quality in the affected files by 0.62%.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 0.32 β | 0.42 β | 0.10 π |
Method Length | 49.51 β | 48.31 β | -1.20 π |
Working memory | 7.25 π | 6.48 π | -0.77 π |
Quality | 75.56% β | 74.94% π | -0.62% π |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 854 | 556 | -298 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
aa_project/settings/base.py | 54.25% π | 54.24% π | -0.01% π |
aa_project/settings/dev.py | 88.36% β | 88.68% β | 0.32% π |
aa_project/settings/pytest/pytest.py | 85.53% β | 85.12% β | -0.41% π |
apps/users/models.py | 90.82% β | 90.82% β | 0.00% |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|---|---|---|---|---|---|
apps/users/models.py | EmailToken.save | 2 β | 46 β | 11 π | 73.24% π | Extract out complex expressions |
The emojis denote the absolute quality of the code:
The π and π indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
Merging #177 (d913e87) into main (779674d) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #177 +/- ##
=======================================
Coverage 89.12% 89.12%
=======================================
Files 61 61
Lines 1618 1619 +1
Branches 199 199
=======================================
+ Hits 1442 1443 +1
Misses 154 154
Partials 22 22
Flag | Coverage Ξ | |
---|---|---|
unittests | 89.12% <100.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Ξ | |
---|---|---|
aa_project/settings/base.py | 100.00% <100.00%> (ΓΈ) |
|
apps/users/models.py | 93.67% <100.00%> (ΓΈ) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update 779674d...d913e87. Read the comment docs.
Addresses the following:
django-cryptography
packagedjango-encrypted-model-fields
packageFIELD_ENCRYPTION_KEY
setting and environment variableEncryptedCharField
as the field type foremail_token
fieldFIELD_ENCRYPTION_KEY
to pytest settingContributes towards: #107