WayofTime / BloodMagic

The place where all of my mod stuffs is!
Other
297 stars 272 forks source link

Forsaken Souls/Fractured Crystal unintended interaction #1070

Open Nightcaste opened 7 years ago

Nightcaste commented 7 years ago

Issue Description:

When attempting to automate Demon Will Crystal farming, Crack of the Fractured Crystal does not activate properly.

Note: If this bug occurs in a modpack, please report this to the modpack author.

In reference to the above note, this does happen in both the Sky Factory 3 modpack as well as the Direwolf20 modpack. Since it happens in more than one pack, it is my opinion that it is not related to the fact that it's in a modpack.

What happens:

Demon Will crystal buds to not break. Mobs do take damage. Crystal buds will form. If you try breaking the ritual stones to rebuild, lava comes pouring out.

I suspect that due to the ritual stones from two different rituals being intermixed, that one of the rituals is being recognized as Serenade of the Nether instead of the one it's supposed to be. Perhaps changing the pattern of ritual stones so that this overlap in layouts is averted would resolve the issue.

What you expected to happen:

Secondary crystal buds break off of main crystal and become entities in the environment to be collected.

Steps to reproduce:

  1. Place Master Ritual Stone for Crack of the Fractured Crystal
  2. Using Ritual Diviner [Dusk] place ritual stones for Crack of the Fractured Crystal
  3. Place Master Ritual Stone for Gathering of the Forsaken Souls on top of Master Ritual Stone for Crack of the Fractured Crystal
  4. Using Ritual Diviner [Dusk] place ritual stones for Gathering of the Forsaken Souls
  5. Using Weak Activation Crystal, activate Gathering of the Forsaken Souls
  6. Using Weak Activation Crystal, activate Crack of the Fractured Crystal

Note: I may have the names of the two rituals reversed. I have included a screenshot of the interlocked rituals: http://puu.sh/umvMM/96bb44910a.png


Affected Versions (Do not use "latest"):

TehNut commented 7 years ago

I think your assumption is correct. I'll sort the ritual list by largest ritual (most components) to smallest and then search in that order. Should solve this issue.

Nightcaste commented 7 years ago

Thank you for the quick response. I'm looking forward to the update.

TehNut commented 7 years ago

Actually, now that I'm looking at the ritual layouts themselves, that shouldn't cause a Serenade to start. After activation, could you look at the MRS and make sure the Waila tooltip is displaying the proper ritual?

Nightcaste commented 7 years ago

The upper MRS does indicate Gathering of the Forsaken Souls, the lower indicates Crack of the Fractured Crystal.

Interestingly, I just took the pieces you can break off, crafted them into the root crystal, and placed that root crystal directly on the ritual stones (as opposed to the crystallizers you can see in my previous screenshot) and things appear to be working properly now. I don't get it, but there it is.

Maybe it wasn't recognizing the crystals in the crystallizers because they were there before the ritual was placed? That's the only thing I can think of, because it's going like gangbusters now.

WayofTime commented 7 years ago

Your crystals don't seem to be in the default range of the rituals. The crystals need to be above the Gathering Souls ritual and below the Fracture ritual. Mob hurting range of the Souls ritual is big, but since you put it on top it might be just far enough away to not hit them.

You can try using the Ritual Tinkerer to alter the ranges.

Nightcaste commented 7 years ago

Your crystals don't seem to be in the default range of the rituals.

As I said, those were placed before the rituals, I was manually filling up the Tartaric gem and putting it in the crucible to get the root crystals to form.

Mob hurting range of the Souls ritual is big, but since you put it on top it might be just far enough away to not hit them.

The mobs are taking damage. The issue was that the crystal buds were not breaking.

antofdeath commented 7 years ago

I was having similar issues for a little bit there, after trying to activate and jigger them around for abit I finally got them to work mostly by manually setting the operational zone with the ritual tinkerer. Though... I seem to have some weird decay in demon will.

keraldi commented 5 years ago

Update?