WayofTime / BloodMagic

The place where all of my mod stuffs is!
Other
297 stars 272 forks source link

(1.12.2) Crash with Extra Utilities 2 Transfer Pipe #1226

Open TechnoMysterio opened 6 years ago

TechnoMysterio commented 6 years ago

Issue Description:

I attempted to setup a blank slate automation system for the altar using transfer nodes and filters, so one transfer node took stone from a chest and put it into the altar, and was placed on the altar with a filter whitelisting blank slates, which was then linked to a chest. Game crashed when it tried to put stone into the altar.

Pastebin: https://pastebin.com/uWrh5Fdv

Used Extra Utilities 1.12-1.7.4.


Affected Versions (Do not use "latest"):

TehNut commented 6 years ago

WayofTime.bloodmagic.tile.TileAltar.canInsertItem_postCharset what in the heck

TehNut commented 6 years ago

Try without charset?

TechnoMysterio commented 6 years ago

No crashes after removing charset, although when I set it all up again, the altar took in all the 3 stone blocks I put into the chest at once, took more blood than I expected, and only gave back 1 blank slate.

Darinth commented 6 years ago

Taking in all 3 stone is known and intentional functionality. The only giving back 1 slate is not.

TechnoMysterio commented 6 years ago

Just ran a few more tests, and I can confirm that the altar does have a problem with processing stacks of items. For instance, it can process 2 stone at once, and it uses the correct amount of blood to do so (2 buckets), but it only outputs one blank slate at the end of it. This is also the same for larger stacks of items.

TehNut commented 6 years ago

I know what the problem is. Simple fix.

Note to future me: Currently I'm just setting the output to a copy of the registered recipes output, which will always have a count of 1. I need to set the count to the amount in the input.

TehNut commented 6 years ago

Fixed output size in 5920d9124dff99d3184ecf35848ae085ba06b0e3, but it's unrelated to this issue so I didn't tag it.

keraldi commented 5 years ago

Reminder for current @TehNut