search

WayofTime / BloodMagic

The place where all of my mod stuffs is!
Other
296 stars 273 forks source link

Call of the Zephyr stops working after a while. #1436

Open MentalMouse opened 6 years ago

MentalMouse commented 6 years ago

Issue Description:

I have two CoZ rituals set up, one to sweep up the eggs from the chickens in my sacrifice stack, the other to collect from my farm. Both have their areas tinkered, one has the chest tinkered. When I originally set them up (and managed to get the areas set), they definitely worked, and collected items into their chests.

Over time, however, they seem to stop working. Their MRS still shows the ritual, and does not say Deactivated, but they're not collecting items anymore. Items tossed on top of the ritual (their default area, right) don't vanish either.

Sometimes resetting the suction area restores the function, sometimes not. It's not clear what triggers the rituals to stop working, but a save/reload isn't necessary. ETA: And I just discovered that even breaking and restarting the ritual (and retinkering the area) doesn't necessarily fix it.

What happens:

CoZ rituals stop working without notice or warning.

What you expected to happen:

Rituals to continue working until stopped.

Steps to reproduce:

  1. Make CoZ rituals and something for them to collect (e.g. farm with Harvest Moon). Have some way to void excess items.
  2. Wait, wander around, make other stuff, ???
  3. Check whether CoZ is still gathering items. If so, return to step 2.

    Affected Versions (Do not use "latest"):

afontaine commented 5 years ago

I'm running into a similar issue, but I can narrow down the steps to reproduce:

  1. Make CoZ rituals and something for them to collect (e.g. farm with Harvest Moon). Have some way to void excess items.
  2. Set tinkered area on one ritual.
  3. Set tinkered area on the other ritual.
  4. Check whether the first CoZ is still gathering items.

Affected Versions are:

afontaine commented 5 years ago

After a little more testing, it looks like when a range is modified, it is changed to the same relative rage for all rituals of that type.

https://imgur.com/a/ZHGsvDA

keraldi commented 5 years ago

Connected to Ritual Tinkerer?

Investigate. Bug label.

Puzzledlight commented 5 years ago

Hey all. Just saw this issue and messed around with it in a multiplayer server. Can confirm that changing any player's ritual area with modify all rituals of the same type as in afontaine's imgur post. Tested it with multiple ritual tinkerers, and even got another player to help test, and the effect duplicated. On a related note, should other players be able to change rituals' areas that do not belong to them?

BloodMagic-1.12.2-2.3.3-101

VincentLongiug commented 5 years ago

Same as @afontaine : if you have 2 Call of Zephyr activated, setting areas for one of them will delete the areas of the second and turn it ineffective (even if it's activated). It means you can only use 1 Call of Zepjyr in a row and you need to redefine the areas each time you change which one you're using.

BloodMagic-1.12.2-2.4.1-103

keraldi commented 5 years ago

Ritual Tinkerer is still not quite working correctly and most likely changes the areas for both "Call of the Zephyr" rituals to the same offset.

1636