search

WayofTime / BloodMagic

The place where all of my mod stuffs is!
Other
296 stars 271 forks source link

[Suggestion] Suppress effects when drained too much health for LP #1627

Open Hoimar2 opened 4 years ago

Hoimar2 commented 4 years ago

Issue Description:

When you use a sigil, the beast mode of bound tools, imperfect rituals, and you don't have enough LP in your network, your health is drained. So far so good. But when you die, you usually don't feed enough LP with your health. Then the effect will still occur. Especially for the imperfect ritual "coal block" this is bad. Because you can summon lot's of zombies near your bed and when you have enough zombies, you can use your sentient sword to collect lot's of will.

What happens:

When you use a sigil, the beast mode of a bound tool or imperfect rituals, then regardless how many health is consumed the effect will occur. When you don't have enough LP, the LP of the network is not consumed.

What you expected to happen:

When you use a sigil, the beast mode of a bound tool or an imperfect ritual, and you die because of zero health, it should be checked if the costs covered by the new LP from health. Soul fray should be considered correctly. The rest of your LP should be consumed

Steps to reproduce:

  1. Be sure your network is nearly empty.
  2. Place an imperfect ritual stone with a coal block on top near your bed.
  3. Have nothing in your inventory.
  4. Start the ritual, respawn, start, respawn and so on.

Affected Versions (Do not use "latest"):

wrincewind commented 4 years ago

Huh. So if an imperfect ritual or sigil would kill you, it should kill you and have the effect not take place? or just do nothing?

TBH the 'it does nothing' feels a little... wussy for blood magic. it's meant to be dangerous, you're messing with some risky things here. And the 'it kills you and nothing happens' feels mean and could result in 'huh? What happened? Stupid thing didn't even work!'.

I think it's good how it is, TBH. Allowing you to do rituals 'for a discount' in exchange for killing yourself seems reasonable. I think the zombie-thing is, like, one of the only times it'd be even vaguely beneficial, and even then most mob-farms are about as useful for a lot less inconvenience.

Hoimar2 commented 4 years ago

I don't think it's mean. If you don't care about your life points, it's your fault. And I mean dying minecraft is no seriously bad thing. If you have blood magic and you are careful enough, you don't even loose experience. If you fear beginners would be disappointed if it's not working you can give meaningful message like "Player was too weak to summon a zombie". If the developers share your opinion, maybe it would help to feed the network with the unused LP. But I would take only a part of the consumed health because filling the network is meant to be done with the orbs.

Hoimar2 commented 4 years ago

Maybe what would even be more fair, when there's a probability to have the effect. Exactly as high as the percentage of the fed LP.