Totem of Undying doesn't work if you kill yourself at the blood altar

EternalRisen commented 4 years ago

Issue Description:

I had accidentally killed myself at the blood altar and had a totem of undying in my charm slot (from another mod, I'm using the Valhelsia 3 modpack, one of the admins told me to report the issue here.) and my totem of undying activated, but I still had the screen that you get when you die, so I go back to where I died and my stuff was not there

What happens:

Inventory gets deleted and totem of undying doesn't properly work

What you expected to happen:

Items to have been where I died and for totem of undying to prevent me from actually dying

Steps to reproduce:

Equip a totem of undying in your charm slot or off-hand
kill yourself at the blood alter using the sacrificial knife

Affected Versions (Do not use "latest"):

BloodMagic: 1.16.3-3.0.0-3
Minecraft: 1.16.3
Forge: Unsure

ArchReverence commented 3 years ago

Reconfirming on: Blood Magic: 1.16.4-3.1.3-18 Minecraft: 1.16.5 Forge: 36.2.0

Extra Mods: Just Enough Items: 7.7.1.121

Notes: I was not able to reconfirm items disappearing or despawning in any way as a result of this bug. All items dropped in my tests. This bug is likely the result of the Sacrificial Dagger code, similar to issue #1836. Changing the code mentioned there would likely solve this bug as well.

EternalRisen commented 3 years ago

I believe this occured using the valhelia 3 modpack which involved spawning a tombstone upon death that had all of your items, although the issue at hand mostly occurs with the sacrificial dagger and totem of undying

WayofTime / BloodMagic