search

WayofTime / BloodMagic

The place where all of my mod stuffs is!
Other
298 stars 277 forks source link

Training Bracelet "Deny other upgrades" option doesn't allow debuffs #1910

Open iggyvilla opened 2 years ago

iggyvilla commented 2 years ago

Issue Description:

The "Deny other upgrades" option doesn't allow debuffs to be applied.

What happens:

Activated the Penance of the Leadened Soul with a training bracelet that has the "Deny other upgrades" option ticked on didn't give me the debuff (has a tome with sufficient upgrade points and an arrow in the linked chest, the ritual worked as lightning struck me)

I'm unsure if this is an intended feature or a communication issue but I will report it anyway just in case.

What you expected to happen:

The ritual to grant me the Storm Trooper I debuff.

Steps to reproduce:

  1. Have a training bracelet on with the "Deny other upgrades" option ticked
  2. Activate Penance of the Leadened Soul with the proper items in the linked chest
  3. Will not get the debuff

Affected Versions (Do not use "latest"):

keraldi commented 2 years ago

Training bracelet should only deny progress for training, not explicit upgrading/downgrading through other methods.

Possible fixes in order of sanity:

  1. Only prevent progress towards an upgrade, not unlocking an upgrade (depending on implementation, only progress may exist)
  2. Check for active bracelet, temporarily disable it to apply upgrade/downgrade
  3. Explicitly circumvent bracelet
kaelanspatel commented 2 years ago

+1 on this, with an added change(?) in behavior: Pennance of the Leadened Soul did not activate until I changed the Training Bracelet settings.

When I changed the setting, the ritual activated.