search

WayofTime / BloodMagic

The place where all of my mod stuffs is!
Other
296 stars 271 forks source link

Update Spectral Block/Tile #1979

Open VT-14 opened 9 months ago

VT-14 commented 9 months ago

BlockSpectral.tick was no longer being called. Set up BlockSpectra.getTicker and moved tick logic to TileSpectral.tick. This makes the Spectral Block decay back into the fluid block.

Currently needs review to ensure it works as intended. Other changes may be required (ex. canBeReplaced is depreciated).

Fixes #1978.

mystchonky commented 8 months ago

Why is the functionality moved to the BE ? I don't think this requires a BE

VT-14 commented 8 months ago

It has been two weeks since I did it, but IIRC it is more consistent with the other Block Entities (Tiles) in the mod (I looked at the Hellfire Forge when trying to work out how it is supposed to work), and the BE had the data like State, Position, and Level already in it.

mystchonky commented 8 months ago

oh okay! Then it makes sense. Move the blockEntity type check from block to BE for consistency as well (Other mods do it in BE as well)

WayofTime commented 5 months ago

While this does technically work, the fluid seems to revert way too quickly. Ideally we would want a solution that makes it not revert at all while the player is around, such as by resetting the decaying process. This was done previously by having it handled by the TileEntity (are they called Block Entity or BE now?), and the sigil would refresh the TE's progress.