WayofTime / BloodMagic

The place where all of my mod stuffs is!
Other
295 stars 271 forks source link

[1.20.1] Certus quartz crystal does not summon a meteor using Mark of Fallen Tower #2043

Open walksanatora opened 2 weeks ago

walksanatora commented 2 weeks ago

Issue Description:

when dropping certus quartz onto the master stone for the ritual. nothing happens which it should (according to the book) spawn a meteor containg (supposedly) ae2 stuff

What happens:

nothing

What you expected to happen:

meteor of ae2 certus/skystone

Steps to reproduce:

  1. download blood magic + deps
  2. download ae2
  3. get 1mil LP
  4. activate ritual
  5. drop cerus onto master ritual stone
  6. cry

Affected Versions (Do not use "latest"):

walksanatora commented 2 weeks ago

upon further looking it appears because ae2's name was change from appliedenergistics2 to just ae2 https://github.com/WayofTime/BloodMagic/blob/1.20.1/src/main/resources/data/bloodmagic/recipes/meteor/ae2.json#L8C21-L8C40

walksanatora commented 2 weeks ago

so I tried fixing the json to be

{
  "type": "forge:conditional",
  "recipes": [
    {
      "conditions": [
        {
          "type": "forge:mod_loaded",
          "modid": "ae2"
        }
      ],
      "recipe": {
        "type": "bloodmagic:meteor",
        "input": {
          "tag": "forge:gems/certus_quartz"
        },
        "syphon": 500000,
        "explosion": 24.0,
        "layers": [
          {
            "radius": 1,
            "additionalWeight": 0,
            "minWeight": 0,
            "weightMap": {},
            "fill": "ae2:flawless_budding_quartz",
            "shell": "ae2:fluix_block"
          },
          {
            "radius": 3,
            "additionalWeight": 0,
            "minWeight": 0,
            "weightMap": [
              {
                "tag": "ae2:fluix_block",
                "weight": 100
              }
            ],
            "fill": "ae2:sky_stone_block"
          },
          {
            "radius": 8,
            "additionalWeight": 100,
            "minWeight": 0,
            "weightMap": [
              {
                "tag": "#forge:storage_blocks/quartz#0",
                "weight": 50
              }
            ],
            "fill": "ae2:sky_stone_block",
            "shell": "ae2:sky_stone_block"
          }
        ]
      }
    }
  ]
}

but this has the unfortunate side effect of dropping ~19 blocks of flawless budding certus in item form