WayofTime / BloodMagic

The place where all of my mod stuffs is!
Other
295 stars 271 forks source link

HUD location adjustments not saved by default #2050

Open stellanera98 opened 5 days ago

stellanera98 commented 5 days ago

Issue Description:

Shift + Right Click with an item that provides a HUD opens a GUI to move them around so you have the option to put them whereever you want them to be. This works great until you leave the world. The location this is supposed to save to is config/bloodmagic/hud_elements.json but the config/bloodmagic folder does not exist anymore and so the path cannot be found. Creating the bloodmagic folder manually solves this.

I guess the simplest way to fix that would be to have it save to config/bloodmagic-hud_elements.json instead. The config folder already exists (or is created by mc/forge) and its more in style with current config naming. Or have forge/mc create the bloodmagic folder, however currently hud_elements.json would be the only file in there and I dont know if the -client and -server.toml can be moved. The forge doc doesnt suggest so.

What happens:

The HUD positions configured reset to default for each individual session since it cannot save it

What you expected to happen:

The HUD positions to be persistent even between sessions in the same world (or instance rather)

Steps to reproduce:

  1. Open the HUD config screen by shift+right click with any of the items (holding/divination/seer sigil, demon will aura gauge)
  2. Rearrange the elements in some way
  3. Click the save button
  4. Notice there is an error printed in the console
  5. Leave the world
  6. Open the world again
  7. Notice the elements are in their default position
  8. Create the bloodmagic folder in the config folder
  9. Repeat 1-6, no error in console and elements stay in the rearranged positions

Affected Versions (Do not use "latest"):