search

WayofTime / BloodMagic

The place where all of my mod stuffs is!
Other
299 stars 277 forks source link

Teleporting to a player with an abnormally large blood network crashes other players games when nearby. #2066

Open Mick0604 opened 1 month ago

Mick0604 commented 1 month ago

Issue Description:

Teleporting to a player with an abnormally large blood network crashes other players games when nearby.

What happens:

i use a waystone or /tpa to my friend and it tends to crash my game when im near his base. i was receiving an embeddium error and when i went to report it they told me that it was blood magic causing the issue.

What you expected to happen:

not crashing

Steps to reproduce:

  1. have lots of blood in a blood network
  2. teleport near player with blood network
  3. crash ...

Affected Versions (Do not use "latest"):

Mick0604 commented 1 month ago

crash-2024-09-23_12.06.09-client.txt latest (1).log crash-2024-09-23_12.09.26-client.txt

Mick0604 commented 1 month ago

here are some logs and crash reports

wrincewind commented 1 month ago

Can you be more specific? how much is 'lots of blood'? are we talking 1m+ LP? a full max-level orb filled beyond its usual limit with runes of the orb? It'll really help with testing if we know the exact parameters.

Mick0604 commented 1 month ago

ill have to ask my friend hold on

wrincewind commented 1 month ago

Also, I see you're running Sodium - does this error still occur with Sodium disabled?

Mick0604 commented 1 month ago

It was around 150000 LP

Mick0604 commented 1 month ago

i did not test without sodium because its very hard to get good performance with the game without it i can try though

VT-14 commented 1 month ago

i was receiving an embeddium error and when i went to report it they told me that it was blood magic causing the issue.

What did they actually say, because I'm not seeing anything related to Blood Magic in those logs other than it simply being installed. Why do they think Soul Network fill level is related at all?

crash-2024-09-23_12.09.26-client.txt

Starting at Line 87 there's:

-- Block being got -- Details: Location: World: (83,145,1176),

What is at that location? From line 137 it's crashing while generating a campfire smoke particle (which I don't think Blood Magic uses anywhere).

I have no useful insight on the other crash report. It's a very different crash, but also mentioning a missing pallet.

stellanera98 commented 1 month ago

The only kind of smoke particle BM is using (AFAIK) is the one where the altar doesnt have any blood during a craft to indicate its loosing progress. But thats not the same kind of smoke particle the campfire uses. I also cant see anything that would indicate its a BM error.

There was a report of BM causing a crash when you right click another player (or entity in general) with either a Seer or Divination sigil but that wouldnt have anything to do with teleporting or the crash reports you put here

Mick0604 commented 1 month ago

Alright well I appreciate the help nonetheless. Thank you for helping me find out what was causing the issue