WayofTime / BloodMagic

The place where all of my mod stuffs is!
Other
298 stars 273 forks source link

Request: Tinkers Construct 1.10.2 integration. #983

Open Kaisoul opened 7 years ago

Kaisoul commented 7 years ago

I would like to request that an integration be made with 1.10.2 version of tinkers construct. I would like to see a material or modifier added that let us collect demon will with a TiCon weapon/tool as an alternative to gather will.

I enjoy blood magic but i dislike being tied to the blood magic sword.

egypt commented 7 years ago

+1. The obvious recipe is a tartaric gem as a modifier in the tool station/forge.

Jomik commented 7 years ago

I'd like this as well. For 1.11.2 though. Rather than a tartaric gem in a tool forge, would it perhaps be possible to imbue the weapon/tool in a Blood Altar like the current sentient weapons? I think this should be possible if you add the modifier in TiCon and then apply it like a crafting recipe? Then you can also make multiple levels and requirements for higher tiers.

xenxero1 commented 7 years ago

It'd probably go smoother to create something specific in the hellfire forge, like a modified tartaric Gem recipe, to get an item that goes on a tool in a modifier slot, if not a tartaric gem itself. Also, potential internal demon will storage/buffer? It might be worth posting this to the TiCon page as well, seeing as this could be done from either side just as easily.

oxinabox commented 7 years ago

This would be really great, because it is a pain to have to chose between my sweet tinkers construct weapon -- which is fun to use cos it is customised for what I like, vs using my sentient sword cos I just really need to get more demonic will.

I guess more generally adding a way to enchant the will stealing effect on a wapon from any mod that accepts vanilla style enchantmenrts would be good (eg an enchanted book recipe)

keraldi commented 5 years ago

Invalid.

Jomik commented 5 years ago

@Iorce That is very descriptive. How and why?

keraldi commented 5 years ago

I requested a cleanup of the Github issues to the maintainer (TehNut) who tasked me to comment on the Github issues with how to proceed with them. My answer is therefore not exactly user facing.

It has been mentioned a couple times in different locations that mod integration is the job of the integrating mods (in this case Tinker's Construct) or of addons because it would bloat BloodMagic too much adding support for all the mods out there not to mention that it might not be feasible.

While I personally agree that support for Tinker's Construct could be fit into BloodMagic, it has been mentioned multiple times specifically for this case that it should be implemented by an addon for BloodMagic.

BloodArsenal by @Arcaratus has, to my knowledge, an implementation for Tinker's Construct support in BloodMagic or is in the works.

Jomik commented 5 years ago

Makes perfect sense! 👍 And I do agree that it'd be better to either put in its own addon or in TiCon.