Issues accessing global variables GM on FF

WazeDev / WME-Place-Harmonizer

Harmonize, format, and lock Waze places

13 stars 18 forks source link

Issues accessing global variables GM on FF #115

Open RavenDT opened 7 years ago

RavenDT commented 7 years ago

Due to increasingly stringent security policies, Greasemonkey won't allow access to global variables for scripts that have any @grant's due to sandboxing.

Solution: Add support to check for window.W vs unsafeWindow.W and then assigning other variables based on that determination.

This will be addressed in the first stage of the refactor.

mapomatic commented 7 years ago

I'm tinkering with the idea of making a temporary branch off of release 1.2 that would remove the one feature that currently requires the @grants (the jQuery UI combo box for adding a street). I don't think it would take much work. We could hand that out to individuals that complain, with the stipulation that they'll need to switch back when the next major update is complete.

crazycaveman commented 7 years ago

Would it be possible to update the Greasemonkey branch to the latest version so those of us on Firefox can still use it?

Submitted #170 for this

mapomatic commented 7 years ago

Done. Thanks for the pull request.

grant commented 7 years ago

Please use ticks (`) before @grant next time please!

mapomatic commented 7 years ago

Apologies :)