search

We-Amp / ngx_pagespeed

Automatic PageSpeed optimization module for Nginx
http://ngxpagespeed.com/
Apache License 2.0
22 stars 1 forks source link

gzip: enable for IPRO as well & style fixes #2

Closed oschaaf closed 10 years ago

oschaaf commented 10 years ago

2 commits: c08ac0eebf9c4f50bcdd9c775a67f2bd0cc3da0c: style fixes (and a few notes) c7685059903d1ce1ef25c4baf4eaaac8c05f3693: also enable gzip when IPRO is on

@keesspoelstra please have a good look at both commits. a few notes need addressing (see) "@keesspoelstra" and after that I think this is set.

peterbowey commented 10 years ago

@oschaaf Many thanks for doing this "gzip" ngx_* revision!

For my own testing purposes, is it correct to pull this via: 'oschaaf-review-keesspoelstra-gzip-enable-trunk' @ https://github.com/We-Amp/ngx_pagespeed.git ?

I realize some of this 'change' is pending 'commentary' to (see) "@keesspoelstra"

oschaaf commented 10 years ago

@peterbowey "For my own testing purposes, is it correct to pull this via: 'oschaaf-review-keesspoelstra-gzip-enable-trunk' " Yes. It looks like this is functionally complete - so we'd actually appreciate it if you gave it a shot :-) @keesspoelstra will have a look at my proposed changes later today - and if he thinks this looks good we will make a pull request out of this to the official repo.

peterbowey commented 10 years ago

@oschaaf Thanks, I will give this pull a 'shot' ;-) Likewise, I appreciate your own input, along with many team members 'others' that fuel this great project!

oschaaf commented 10 years ago

I see I made a mistake - and made the pull to the wrong branch. I'll re-open to the correct one. Sorry!