We-the-People-civ4col-mod / Mod

This is the repository where the mod resides.
90 stars 37 forks source link

Shipborne units always display the tooltip for Mounted Conquistadors on ≥2 hovers #893

Open MatthewForrester opened 1 year ago

MatthewForrester commented 1 year ago

Steps to reproduce

  1. Load the following save in WTP 4.02: Hernan Cortes AD-1599-January.ColonizationSave.zip
  2. Open the city of La Isabela
  3. Empty a ship of cargo
  4. Move the Colonial Militia onto any slot in the ship
  5. Hover over the Colonial Militia. The tooltip displays the correct information.
  6. Hover over the same unit.

Expected result The tooltip reappears with the correct information.

Actual result The tooltop incorrectly displays the information for a Mounted Conquistador: image Repeating step 6 reproduces the same behaviour.

Observations The same behaviour can be reproduced with other units. This exact behaviour can't be reproduced with shipborne goods, but no tooltip at all appears, which might be a symptom of the same bug.

Notes WTP: 4.0.2 from Github. Civ4Col: Steam original_release_unsupported beta OS: Ubuntu 22.04.3

Schmiddie1979 commented 1 year ago

I have tested it, I cannot reproduce this bug. Works as designed for me:

image

MrZorG33 commented 1 year ago

I confirm this error (was relevant for 4.0.2). I already talked about it in the developer chat back in early spring. I have a video (sent by a subscriber to my group), but playback does not work here (only on the VK social network). image

however, now I can't reproduce it in develop - it has transformed into another error. When you hover the cursor for the first time, everything is ok, but when you hover the cursor again, the help is not shown at all (help is available only for transport). image

image

MatthewForrester commented 1 year ago

I have tested it, I cannot reproduce this bug.

Thank you for taking the time to reproduce this. Was this tested on the same setup (4.02/Steam/Linux?), please? I see that you are a well-established collaborator and so perhaps you didn't see the need to state that or know why that is not significant. However, as I am new to this community so things that are obvious to you may not be obvious to me.

I confirm this error (was relevant for 4.0.2). I already talked about it in the developer chat back in early spring. I have a video (sent by a subscriber to my group), but playback does not work here (only on the VK social network).

Thank you for taking the time to comment. A video is a good idea, so here is a gif: Shipborne-unit-bug

Note that the first mouseover is fine; it's the second and subsequent ones that are ineffective.

In the course of making this recording, I discovered that alt-tabbing and entering/exiting the city both reset the mouseover count for this purpose.