search

We-the-People-civ4col-mod / Mod

This is the repository where the mod resides.
90 stars 37 forks source link

Update the colopedia so it correctly reflects the mechanics of storage, overflow and customs selling #90

Open ShadesOT opened 6 years ago

ShadesOT commented 6 years ago

The colopedia is pretty good, but in some details not precise and sometimes misleading.

1) The code says, that a customs building is not selling the excess over the max storage capacity (as says the colopedia), but it is selling the loss of the excess.

soldByCustomsBuilding = = loss customsBuildingSpecificSellPercentage = = excess lossPercentage buildingSpecificSellPercentage = = (goodsInStorage - storageCapacity) lossPercentage * buildingSpecificSellPercentage

2) Currently lumber and stone do not contribute to the amount of goods in the storage. But this should be fixed in the code in the way, that they do contribute, not in the colopedia.

3) The warehouse building that sells 50% and what it does exactly is not mentioned in the game concept CONCEPT_NEW_STORAGE

4) Cleanup: To be checked for consistency: CONCEPT_NEW_STORAGE, all storage type buildings

5) The colopedia does not mention in detail, that when a customs building sells to europe and the good is boycotted, the kings tax still is deducted.

ShadesOT commented 6 years ago

The tooltip in a city over a customs house actually also tells that "Goods over storage capacity are sold at xx% of the price in Europe", but, as mentioned, only the lost part of the overflow is sold. Well, one could argue, that not all of the overflow is sold at once and thus the tooltip is correct. But this behavior and documentation of the customs house has led to various forum questions by puzzeled users. Maybe the tooltip should say: "Goods over storage capacity are sold bit by bit at xx% of the price in Europe"